fix(Loading): wc parity issues #18343
Merged
+79
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for carbon-elements ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for v11-carbon-react ready!Built without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
tay1orjones
requested review from
a team and
judithbenjamin
and removed request for
a team
|
Hey, thanks for putting up this PR! I just added @aagonzales as a reviewer to be sure we get a ux and visual review on this. |
✅ Deploy Preview for v11-carbon-web-components ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #18343 +/- ##
=======================================
Coverage 84.92% 84.92%
=======================================
Files 408 408
Lines 14501 14501
Branches 4679 4679
=======================================
Hits 12315 12315
Misses 2026 2026
Partials 160 160 ☔ View full report in Codecov by Sentry. |
aagonzales
approved these changes
Feb 5, 2025
packages/web-components/src/components/loading/loading.stories.ts
Outdated
Show resolved
Hide resolved
ariellalgilmore
approved these changes
Feb 13, 2025
Merged
via the queue into
carbon-design-system:main
with commit Feb 19, 2025
9883920
38 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #17925
Fixing parities in Loading component between react and webcomponent. Below props in webcomponents was not matching with what we have in react. So added new props and deprecating the respective ones to match with React
Changelog
Changed
Testing / Reviewing
Can be verified in storybook controls